chore: cre spell out ExecuteOperation type parameters#26
Merged
Conversation
ajaskolski
changed the title
ajaskolski
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the fwops.ExecuteOperation generic type parameters explicit at call sites to keep the resulting Report typing more obvious and less reliant on inference, without changing behavior.
Changes:
- Update CRE workflow deploy operation execution in tests to use explicit
ExecuteOperation[Input, Output, Deps]type parameters. - Update the CRE workflow deploy changeset to use explicit
ExecuteOperation[Input, Output, Deps]type parameters.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cre/operations/workflow_deploy_test.go |
Makes ExecuteOperation type parameters explicit in the workflow deploy operation test. |
cre/changesets/workflow_deploy.go |
Makes ExecuteOperation type parameters explicit in the workflow deploy changeset application flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ecPablo
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chainlink-deployments-framework operations API defines ExecuteOperation as a generic over those three types. Inference already resolves them today. Making them explicit keeps the Report output typing obvious at the call site. No breaking change.